-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small onboarding tweaks to Welcome template #928
Conversation
<% end %> | ||
<% unless defined?(Dradis::Pro) && defined?(Dradis::Pro::Plugins::Remediationtracker) %> | ||
<% if sync_plugins.any? %> | ||
<div class="divider"></div> | ||
<% end %> | ||
<a href="javascript:void(0)" class="js-try-pro dropdown-item" data-term="remediation" data-url="https://dradisframework.com/pro/add-ons/remediation.html"><i class="fa fa-tasks fa-fw"></i> Built-in Remediation Tracker</a> | ||
<a href="javascript:void(0)" class="js-try-pro dropdown-item" data-term="remediation" data-url="https://dradisframework.com/tools/remediation.html"><i class="fa fa-check-square-o fa-fw"></i> Built-in Remediation Tracker</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We specifically use pro/pages|addons for these modals because we are styling the pages in mind that they are likely viewed in a modal (hiding the website navbar & footer, and some other small adjustments).
I think a better approach would be to keep the pro/pages link here and update the pro/pages/remdiation.html page on the website
Needs a |
<% unless defined?(Dradis::Pro) && defined?(Dradis::Plugins::Vsts) %> | ||
<a href="javascript:void(0)" class="js-try-pro dropdown-item" data-term="jira" data-url="https://dradisframework.com/pro/add-ons/jira.html"><i class="fa fa-bolt fa-fw"></i> Ticketing: JIRA</a> | ||
<% end %> | ||
<% unless defined?(Dradis::Pro) && defined?(Dradis::Plugins::Vsts) %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<% unless defined?(Dradis::Pro) && defined?(Dradis::Plugins::Vsts) %> | |
<% unless defined?(Dradis::Pro) && defined?(Dradis::Plugins::Servicenow) %> |
Co-authored-by: Aaron Manaloto <[email protected]>
Summary
A few small changes to make the Welcome project a bit more colorful (more users other than
adama@
).Check List